netdev - RE: [PATCH net-next v6 7/7] bonding: Selftest and documentation for the arp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MW3PR15MB391369040A414B4AED6F5301FA5DA@MW3PR15MB3913.namprd15.prod.outlook.com>
Date: Mon, 21 Jul 2025 17:47:50 +0000
From: David Wilder <wilder@...ibm.com>
To: Simon Horman <horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jv@...sburgh.net"
	<jv@...sburgh.net>,
        "pradeeps@...ux.vnet.ibm.com"
	<pradeeps@...ux.vnet.ibm.com>,
        Pradeep Satyanarayana <pradeep@...ibm.com>,
        "i.maximets@....org" <i.maximets@....org>,
        Adrian Moreno Zapata
	<amorenoz@...hat.com>,
        Hangbin Liu <haliu@...hat.com>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: RE: [PATCH net-next v6 7/7] bonding: Selftest and documentation for
 the arp_ip_target parameter.




________________________________________
From: Simon Horman <horms@...nel.org>
Sent: Sunday, July 20, 2025 3:37 AM
To: David Wilder
Cc: netdev@...r.kernel.org; jv@...sburgh.net; pradeeps@...ux.vnet.ibm.com; Pradeep Satyanarayana; i.maximets@....org; Adrian Moreno Zapata; Hangbin Liu; stephen@...workplumber.org
Subject: [EXTERNAL] Re: [PATCH net-next v6 7/7] bonding: Selftest and documentation for the arp_ip_target parameter.

>On Fri, Jul 18, 2025 at 02:23:43PM -0700, David Wilder wrote:
>> This selftest provided a functional test for the arp_ip_target parameter
>> both with and without user supplied vlan tags.
>>
>> and
>>
>> Updates to the bonding documentation.
>>
>> Signed-off-by: David Wilder <wilder@...ibm.com>
>> ---
>>  Documentation/networking/bonding.rst          |  11 ++
>>  .../selftests/drivers/net/bonding/Makefile    |   3 +-
>>  .../drivers/net/bonding/bond-arp-ip-target.sh | 178 ++++++++++++++++++
>
>Hi David,
>
>Recently we have started running shellcheck as part of our CI for Networking.
>
>Excluding SC2317, which flagges code as unreachable due to
>the structure of many sleftests, including this one, I think it is trivial
>to make bond-arp-ip-target.sh selftest-clean.
>
>As I see there will be a v7 anyway, could you take a look at doing so?
>
>  $ shellcheck -e SC2317 ./tools/testing/selftests/drivers/net/bonding/bond-arp-ip-target.sh
>
>  In ./tools/testing/selftests/drivers/net/bonding/bond-arp-ip-target.sh line 133:
>                  if [ $RET -ne 0 ]; then
>                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
>
>  Did you mean:
>                  if [ "$RET" -ne 0 ]; then
>
>
>  In ./tools/testing/selftests/drivers/net/bonding/bond-arp-ip-target.sh line 160:
>                  if [ $RET -ne 0 ]; then
>                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
>
>  Did you mean:
>                  if [ "$RET" -ne 0 ]; then
>
>  For more information:
>    https://www.shellcheck.net/wiki/SC2086   -- Double quote to prevent globbing ...
>
>
>And sorry for not flagging this earlier.
>For some reason it seemed less clear to me the last time I checked.

Hi Simon
Thanks for flagging the shellcheck errors.  I apparently had
installed old version of shellcheck that was not flagging SC2317
or the un-quoted $RET.  After upgrading to V0.10.0. I see them now.
I fixed the $RET issue and added # shellcheck disable=SC2317.
Runs clean now.  I will update the test script for V7.