netdev - [PATCH] usbnet: Set duplex status to unknown in the absence of MII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250721071022.1062495-1-yicongsrfy@163.com>
Date: Mon, 21 Jul 2025 15:10:22 +0800
From: yicongsrfy@....com
To: oneukum@...e.com,
	andrew+netdev@...n.ch,
	davem@...emloft.net
Cc: netdev@...r.kernel.org,
	linux-usb@...r.kernel.org,
	Yi Cong <yicong@...inos.cn>
Subject: [PATCH] usbnet: Set duplex status to unknown in the absence of MII

From: Yi Cong <yicong@...inos.cn>

CDC device don't use mdio to get link status, duplex is set
half as default.

Now cdc_ncm can't get duplex, set it UNKNOWN instead of half
which might actually be in an error state.

Signed-off-by: Yi Cong <yicong@...inos.cn>
---
 drivers/net/usb/usbnet.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 6a3cca104af9..c612f8f606e5 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1013,6 +1013,11 @@ int usbnet_get_link_ksettings_internal(struct net_device *net,
 	else
 		cmd->base.speed = SPEED_UNKNOWN;
 
+	/* Now we can't get link duplex without MII,
+	 * set it DUPLEX_UNKNOWN instead of default DUPLEX_HALF
+	 */
+	cmd->base.duplex = DUPLEX_UNKNOWN;
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usbnet_get_link_ksettings_internal);
-- 
2.25.1