netdev - Re: [PATCH 1/1] s390/ism: fix concurrency management in ism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b09d374-528a-4a6d-a6c6-2be840e8a52b-agordeev@linux.ibm.com>
Date: Mon, 21 Jul 2025 09:30:08 +0200
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Halil Pasic <pasic@...ux.ibm.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexandra Winter <wintera@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Sebastian Ott <sebott@...ux.ibm.com>,
        Ursula Braun <ubraun@...ux.ibm.com>, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Aliaksei Makarau <Aliaksei.Makarau@....com>,
        Mahanta Jambigi <mjambigi@...ux.ibm.com>
Subject: Re: [PATCH 1/1] s390/ism: fix concurrency management in ism_cmd()

On Sun, Jul 20, 2025 at 11:11:09PM +0200, Halil Pasic wrote:

Hi Halil,

...
> @@ -129,7 +129,9 @@ static int ism_cmd(struct ism_dev *ism, void *cmd)
>  {
>  	struct ism_req_hdr *req = cmd;
>  	struct ism_resp_hdr *resp = cmd;
> +	unsigned long flags;
>  
> +	spin_lock_irqsave(&ism->cmd_lock, flags);

I only found smcd_handle_irq() scheduling a tasklet, but no commands issued.
Do we really need disable interrupts?

>  	__ism_write_cmd(ism, req + 1, sizeof(*req), req->len - sizeof(*req));
>  	__ism_write_cmd(ism, req, 0, sizeof(*req));
>  
> @@ -143,6 +145,7 @@ static int ism_cmd(struct ism_dev *ism, void *cmd)
>  	}
>  	__ism_read_cmd(ism, resp + 1, sizeof(*resp), resp->len - sizeof(*resp));
>  out:
> +	spin_unlock_irqrestore(&ism->cmd_lock, flags);
>  	return resp->ret;
>  }
>  
...

Thanks!