netdev - Re: [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250721092912.GZ2459@horms.kernel.org>
Date: Mon, 21 Jul 2025 10:29:12 +0100
From: Simon Horman <horms@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	"Andre B. Oliveira" <anbadeol@...il.com>, linux-can@...r.kernel.org,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104

On Sun, Jul 20, 2025 at 12:22:56PM -0700, Randy Dunlap wrote:
> 
> 
> On 7/19/25 9:50 PM, Vincent Mailhol wrote:
> > On 20/07/2025 at 09:02, Randy Dunlap wrote:
> >> Add a dependency on PC104 to limit (restrict) this driver kconfig
> >> prompt to kernel configs that have PC104 set.
> >>
> >> Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >> Cc: Andre B. Oliveira <anbadeol@...il.com>
> >> Cc: linux-can@...r.kernel.org
> >> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> >> Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> >> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> >> Cc: "David S. Miller" <davem@...emloft.net>
> >> Cc: Eric Dumazet <edumazet@...gle.com>
> >> Cc: Jakub Kicinski <kuba@...nel.org>
> >> Cc: Paolo Abeni <pabeni@...hat.com>
> >> ---
> >>  drivers/net/can/sja1000/Kconfig |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig
> >> +++ linux-next-20250718/drivers/net/can/sja1000/Kconfig
> >> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
> >>  
> >>  config CAN_TSCAN1
> >>  	tristate "TS-CAN1 PC104 boards"
> >> -	depends on ISA
> >> +	depends on ISA && PC104
> > 
> > A bit unrelated but ISA depends on X86_32 so I would suggest to add a
> > COMPILE_TEST so that people can still do test builds on x86_64.
> > 
> >   depends on (ISA && PC104) || COMPILE_TEST
> 
> Sure, I can change that and see if any robots find problems with it.
> 
> I did a few x86_64 builds with PC104 not set, COMPILE_TEST set,
> and CAN_TSCAN1 = y / m. I didn't encounter any problems.

Thanks.

FWIIW, I agree that extending build coverage using COMPILE_TEST is a good idea.