netdev - RE: [Intel-wired-lan] [PATCH net] i40e: report VF tx_dropped with tx_errors instead of tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8985803B020C69688F642F1A8F5DA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Mon, 21 Jul 2025 09:46:08 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, Dennis Chen <dechen@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>
Subject: RE: [Intel-wired-lan] [PATCH net] i40e: report VF tx_dropped with
 tx_errors instead of tx_discards

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Simon
> Horman
> Sent: Monday, June 30, 2025 6:50 PM
> To: Dennis Chen <dechen@...hat.com>
> Cc: netdev@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; andrew+netdev@...n.ch;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; intel-wired-lan@...ts.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH net] i40e: report VF tx_dropped with
> tx_errors instead of tx_discards
> 
> On Wed, Jun 18, 2025 at 03:52:40PM -0400, Dennis Chen wrote:
> > Currently the tx_dropped field in VF stats is not updated correctly
> > when reading stats from the PF. This is because it reads from
> > i40e_eth_stats.tx_discards which seems to be unused for per VSI stats,
> > as it is not updated by i40e_update_eth_stats() and the corresponding
> > register, GLV_TDPC, is not implemented[1].
> >
> > Use i40e_eth_stats.tx_errors instead, which is actually updated by
> > i40e_update_eth_stats() by reading from GLV_TEPC.
> 
> ...
> 
> > Fixes: dc645daef9af5bcbd9c ("i40e: implement VF stats NDO")
> > Signed-off-by: Dennis Chen <dechen@...hat.com>
> >     Link:
> > https://www.intel.com/content/www/us/en/content-details/596333/intel-e
> > thernet-controller-x710-tm4-at2-carlsville-datasheet.html
> 
> Hi Dennis,
> 
> Thanks for the detailed explanation, it's very much appreciated.
> 
> One minor nit, is that there are some leading spaces before "Link: "
> a few lines above. But I suspect you don't need to repost just to address that.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>