netdev - Re: [PATCH net-next v3] ptp: add Alibaba CIPU PTP clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49c4e674-ab1e-4947-9885-5c73810368eb@redhat.com>
Date: Tue, 22 Jul 2025 11:13:40 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Wen Gu <guwen@...ux.alibaba.com>, richardcochran@...il.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org
Cc: xuanzhuo@...ux.alibaba.com, dust.li@...ux.alibaba.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] ptp: add Alibaba CIPU PTP clock driver

On 7/17/25 9:57 AM, Wen Gu wrote:
> +#define PTP_CIPU_BAR_0	0
> +#define PTP_CIPU_REG(reg) \
> +	offsetof(struct ptp_cipu_regs, reg)

Minor nit: no need to use a multiple line macro above

[...]
> +static void ptp_cipu_clear_context(struct ptp_cipu_ctx *ptp_ctx)
> +{
> +	cancel_delayed_work_sync(&ptp_ctx->gen_timer);
> +	cancel_delayed_work_sync(&ptp_ctx->mt_timer);
> +	cancel_work_sync(&ptp_ctx->sync_work);

You need to use the 'disable_' variant of the above helper, to avoid the
work being rescheduled by the last iteration.

Other than that LGTM, thanks.

Paolo