netdev - Re: [PATCH net-next] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1753181623.6635778-1-xuanzhuo@linux.alibaba.com>
Date: Tue, 22 Jul 2025 18:53:43 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org,
 Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Wen Gu <guwen@...ux.alibaba.com>,
 Philo Lu <lulie@...ux.alibaba.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Lukas Bulwahn <lukas.bulwahn@...hat.com>,
 Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Alexander Duyck <alexanderduyck@...com>,
 Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

On Fri, 18 Jul 2025 18:59:32 +0200, Andrew Lunn <andrew@...n.ch> wrote:
> > We have our own distribution "Anolis".
>
> This driver can be used with any distribution. So it needs to work
> equally well for all distributions.
>
> If you want this feature in Anolis, you can take the upstream version
> and hack in the feature in your downstream kernel.

By inspecting the kernel release string (utsname()->release), we can identify
the Linux distribution in use, such as Anolis, Red Hat, or Ubuntu. This allows
us to provide support for these and other mainstream distributions. While we
plan to offer enhanced support on Anolis and these specific platforms, this
approach will not negatively impact other systems. Therefore, we see this as a
method that can only improve functionality without introducing any drawbacks.

Thanks.

>
> > > No module parameters. You are doing development work, just use $EDITOR
> > > and change the timeout.
> >
> > Our use case has already been explained. We will set a long timeout to help with
> > issue diagnosis, and once the problem is identified, we will immediately adjust
> > the timeout to let the driver exit quickly. Honestly, this is a very useful
> > feature for us during the development process. Of course, it seems that you are
> > strongly opposed to it, so we will remove it in the next version.
>
> We have been pushing back on module parameters for years. You should
> of seen this in multiple review comments on the netdev list.
>
> 	Andrew
>