netdev - Re: [PATCH net-next] net: phy: micrel: Add support for lan8842

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d0b56bd-6a8e-4179-955d-bc0e2a933b20@lunn.ch>
Date: Tue, 22 Jul 2025 15:08:08 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	o.rempel@...gutronix.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for lan8842

> Yes, I will use PHY_ID_MATCH_MODEL().
> I was thinking to start with 2 cleanup patches, one to use
> PHY_ID_MATCH_MODEL in the driver and one to introduce
> lanphy_modify_page_reg and put it to use.
> Do you have other suggestions?

I did not look at the driver too closely. There might be other
cleanups you can do, but those two make sense in the context of what
you are doing.

	Andrew