netdev - RE: [EXTERNAL] Re: [PATCH net] net: core: Fix the loop in default_device_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ2PR21MB401368342203BE4EFF0C6494CA5CA@SJ2PR21MB4013.namprd21.prod.outlook.com>
Date: Tue, 22 Jul 2025 16:15:43 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Eric Dumazet <edumazet@...gle.com>, Haiyang Zhang
	<haiyangz@...ux.microsoft.com>
CC: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, KY Srinivasan
	<kys@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "sdf@...ichev.me" <sdf@...ichev.me>,
	"kuniyu@...gle.com" <kuniyu@...gle.com>, "ahmed.zaki@...el.com"
	<ahmed.zaki@...el.com>, "aleksander.lobakin@...el.com"
	<aleksander.lobakin@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, "#@...ux.microsoft.com" <#@...ux.microsoft.com>,
	"5.4+@...ux.microsoft.com" <5.4+@...ux.microsoft.com>
Subject: RE: [EXTERNAL] Re: [PATCH net] net: core: Fix the loop in
 default_device_exit_net()



> -----Original Message-----
> From: Eric Dumazet <edumazet@...gle.com>
> Sent: Tuesday, July 22, 2025 2:52 AM
> To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
> Cc: linux-hyperv@...r.kernel.org; netdev@...r.kernel.org; Haiyang Zhang
> <haiyangz@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>;
> wei.liu@...nel.org; kuba@...nel.org; pabeni@...hat.com; horms@...nel.org;
> davem@...emloft.net; sdf@...ichev.me; kuniyu@...gle.com;
> ahmed.zaki@...el.com; aleksander.lobakin@...el.com; linux-
> kernel@...r.kernel.org; stable@...r.kernel.org; #@...ux.microsoft.com;
> 5.4+@...ux.microsoft.com
> Subject: [EXTERNAL] Re: [PATCH net] net: core: Fix the loop in
> default_device_exit_net()
> 
> On Fri, Jul 18, 2025 at 1:21 PM Haiyang Zhang
> <haiyangz@...ux.microsoft.com> wrote:
> >
> > From: Haiyang Zhang <haiyangz@...rosoft.com>
> >
> > The loop in default_device_exit_net() won't be able to properly detect
> the
> > head then stop, and will hit NULL pointer, when a driver, like
> hv_netvsc,
> > automatically moves the slave device together with the master device.
> >
> > To fix this, add a helper function to return the first migratable netdev
> > correctly, no matter one or two devices were removed from this net's
> list
> > in the last iteration.
> >
> > Cc: stable@...r.kernel.org # 5.4+
> 
> We (network maintainers) prefer a Fixes: tag, so that we can look at
> the blamed patch, rather than trusting your '5.4' hint.
> 
> Without a Fixes tag, you are forcing each reviewer to do the
> archeology work, and possibly completely miss your point.

Thanks. I will have the Fixes tag in the new patch.

- Haiyang