netdev - Re: [PATCH net-next v2 4/5] gve: implement DQO TX datapath for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEAWyHcLHfyvnLogdqWZR_am9ed+SSOfTp7GfOXBB89Duv_N4Q@mail.gmail.com>
Date: Tue, 22 Jul 2025 10:32:35 -0700
From: Harshitha Ramamurthy <hramamurthy@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Jason Xing <kerneljasonxing@...il.com>, Jeroen de Borst <jeroendb@...gle.com>, 
	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, willemb@...gle.com, Joshua Washington <joshwash@...gle.com>, 
	Praveen Kaligineedi <pkaligineedi@...gle.com>
Subject: Re: [PATCH net-next v2 4/5] gve: implement DQO TX datapath for AF_XDP zero-copy

On Tue, Jul 22, 2025 at 2:32 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 7/22/25 1:37 AM, Jason Xing wrote:
> > On Thu, Jul 17, 2025 at 11:29 PM Jeroen de Borst <jeroendb@...gle.com> wrote:
> >> +
> >> +               pkt = gve_alloc_pending_packet(tx);
> >
> > I checked gve_alloc_pending_packet() and noticed there is one slight
> > chance to return NULL? If so, it will trigger a NULL dereference
> > issue.
>
> IIRC, a similar thing was already mentioned on an older patch. Still
> IIRC, the trick is that there is a previous, successful call to
> gve_has_avail_slots_tx_dqo() that ensures there are free TX packets
> avail and operations racing in between on other CPUs could only add more
> free pkts.
>
> So the above looks safe to me.
>
> Side note: since this looks like a recurrining topic, I guess it would
> be nice a follow-up adding some comments above the relevant functions.

Sounds good, will do in a follow up patch.

Thanks for the discussion and feedback.
>
> Thanks,
>
> Paolo
>