netdev - Re: [PATCH bpf-next v3 05/10] selftests/bpf: Cover verifier checks for skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f7ee402cc9c84b8c9a6747141dc3f7ff866e737.camel@gmail.com>
Date: Tue, 22 Jul 2025 12:22:43 -0700
From: Eduard Zingerman <eddyz87@...il.com>
To: Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc: Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko
 <andrii@...nel.org>,  Arthur Fabre <arthur@...hurfabre.com>, Daniel
 Borkmann <daniel@...earbox.net>, Eric Dumazet	 <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer	 <hawk@...nel.org>,
 Jesse Brandeburg <jbrandeburg@...udflare.com>, Joanne Koong	
 <joannelkoong@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Martin
 KaFai Lau <martin.lau@...ux.dev>, Toke
 Høiland-Jørgensen <thoiland@...hat.com>,  Yan Zhai
 <yan@...udflare.com>, kernel-team@...udflare.com, netdev@...r.kernel.org,
 Stanislav Fomichev	 <sdf@...ichev.me>
Subject: Re: [PATCH bpf-next v3 05/10] selftests/bpf: Cover verifier checks
 for skb_meta dynptr type

On Mon, 2025-07-21 at 12:52 +0200, Jakub Sitnicki wrote:
> dynptr for skb metadata behaves the same way as the dynptr for skb data
> with one exception - writes to skb_meta dynptr don't invalidate existing
> skb and skb_meta slices.
> 
> Duplicate those the skb dynptr tests which we can, since
> bpf_dynptr_from_skb_meta kfunc can be called only from TC BPF, to cover the
> skb_meta dynptr verifier checks.
> 
> Also add a couple of new tests (skb_data_valid_*) to ensure we don't
> invalidate the slices in the mentioned case, which are specific to skb_meta
> dynptr.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---

Acked-by: Eduard Zingerman <eddyz87@...il.com>

[...]