netdev - Re: [PATCH net-next v2 1/3] net: wangxun: change the default ITR setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6ae72a2-76fe-4032-8705-821c2280f9f3@intel.com>
Date: Tue, 22 Jul 2025 14:46:16 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>, <netdev@...r.kernel.org>, "'Andrew
 Lunn'" <andrew+netdev@...n.ch>, "'David S. Miller'" <davem@...emloft.net>,
	'Eric Dumazet' <edumazet@...gle.com>, 'Jakub Kicinski' <kuba@...nel.org>,
	'Paolo Abeni' <pabeni@...hat.com>, 'Simon Horman' <horms@...nel.org>
CC: 'Mengyuan Lou' <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v2 1/3] net: wangxun: change the default ITR
 setting



On 7/21/2025 7:40 PM, Jiawen Wu wrote:
> On Tue, Jul 22, 2025 7:56 AM, Jacob Keller wrote:
>> On 7/21/2025 1:01 AM, Jiawen Wu wrote:
>>
>> It looks like you previously set some of these values here, but now you
>> set them higher up in the function.
>>
>> Its a bit hard to tell whats actually being changed here because of that.
> 
> In fact, here it's just a change of default rx/tx itr for wx_mac_em from
> 20k to 7k. It's an experience value from out-of-tree ngbe driver, to get
> higher performance on various platforms.
> 
> As for the other changes, just cleanup the code for the next patches.
> 
> 

It would be helpful for the rational to be explained in the commit message.

The code seems fine, but I think its just the nature of this diff which
made it hard for me to track what happened.

Thanks,
Jake


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)