netdev - Re: [Intel-wired-lan] [PATCH net-next 1/2] stmmac: xsk: fix underflow of budget in zerocopy mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoA7W=3m2+=EGicrAkiwc2HUGTn3js=0r_gm9=z0BKR3ag@mail.gmail.com>
Date: Wed, 23 Jul 2025 07:04:27 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Paul Menzel <pmenzel@...gen.mpg.de>, anthony.l.nguyen@...el.com, 
	przemyslaw.kitszel@...el.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, bjorn@...nel.org, 
	magnus.karlsson@...el.com, maciej.fijalkowski@...el.com, 
	jonathan.lemon@...il.com, sdf@...ichev.me, ast@...nel.org, 
	daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com, 
	mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com, 
	linux-stm32@...md-mailman.stormreply.com, bpf@...r.kernel.org, 
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 1/2] stmmac: xsk: fix underflow
 of budget in zerocopy mode

On Wed, Jul 23, 2025 at 1:29 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> Jason Xing wrote:
> > On Tue, Jul 22, 2025 at 10:16 PM Willem de Bruijn
> > <willemdebruijn.kernel@...il.com> wrote:
> > >
> > > Jason Xing wrote:
> > > > Hi Paul,
> > > >
> > > > On Mon, Jul 21, 2025 at 4:56 PM Paul Menzel <pmenzel@...gen.mpg.de> wrote:
> > > > >
> > > > > Dear Jason,
> > > > >
> > > > >
> > > > > Thank you for your patch.
> > > >
> > > > Thanks for your quick response and review :)
> > > >
> > > > >
> > > > > Am 21.07.25 um 10:33 schrieb Jason Xing:
> > > > > > From: Jason Xing <kernelxing@...cent.com>
> > > > > >
> > > > > > The issue can happen when the budget number of descs are consumed. As
> > > > >
> > > > > Instead of “The issue”, I’d use “An underflow …”.
> > > >
> > > > Will change it.
> > > >
> > > > >
> > > > > > long as the budget is decreased to zero, it will again go into
> > > > > > while (budget-- > 0) statement and get decreased by one, so the
> > > > > > underflow issue can happen. It will lead to returning true whereas the
> > > > > > expected value should be false.
> > > > >
> > > > > What is “it”?
> > > >
> > > > It means 'underflow of budget' behavior.
> > >
> > > A technicality, but this is (negative) overflow.
> > >
> > > Underflow is a computation that results in a value that is too small
> > > to be represented by the given type.
> >
> > Interesting. Thanks for sharing this with me:)
> >
> > I just checked the wikipedia[1] that says " Underflow can in part be
> > regarded as negative overflow of the exponent of the floating-point
> > value.". I assume this rule can also be applied in this case? I'm
> > hesitant to send the v3 patch tomorrow with this 'negative overflow'
> > term included.
>
> My point is very pedantic. I think these cases are not underflow.
>
> But it is often called that, understandably. So choose as you see fit.

I see. Thanks for pointing that out. I will change it :)

Thanks,
Jason