netdev - Re: [PATCH v2 12/15] net: rnpgbe: Add link up handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <689C469EE0E578FA+20250722064835.GD99399@nic-Precision-5820-Tower>
Date: Tue, 22 Jul 2025 14:48:35 +0800
From: Yibo Dong <dong100@...se.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	corbet@....net, gur.stavi@...wei.com, maddy@...ux.ibm.com,
	mpe@...erman.id.au, danishanwar@...com, lee@...ger.us,
	gongfan1@...wei.com, lorenzo@...nel.org, geert+renesas@...der.be,
	Parthiban.Veerasooran@...rochip.com, lukas.bulwahn@...hat.com,
	alexanderduyck@...com, richardcochran@...il.com,
	netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/15] net: rnpgbe: Add link up handler

On Mon, Jul 21, 2025 at 05:47:09PM +0200, Andrew Lunn wrote:
> On Mon, Jul 21, 2025 at 07:32:35PM +0800, Dong Yibo wrote:
> > Initialize link status handler
> > 
> > Signed-off-by: Dong Yibo <dong100@...se.com>
> > ---
> >  drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h    |  53 +++++
> >  .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c   |  26 +++
> >  .../net/ethernet/mucse/rnpgbe/rnpgbe_lib.c    |   7 +
> >  .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c   | 139 +++++++++++++
> >  .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h    |   1 +
> >  .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c | 187 ++++++++++++++++++
> >  .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h |   7 +
> >  7 files changed, 420 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > index 624e0eec562a..b241740d9cc5 100644
> > --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > @@ -26,6 +26,15 @@ enum rnpgbe_hw_type {
> >  	rnpgbe_hw_unknow
> >  };
> >  
> > +enum speed_enum {
> > +	speed_10,
> > +	speed_100,
> > +	speed_1000,
> > +	speed_10000,
> > +	speed_25000,
> > +	speed_40000,
> 
> Patch 1/X says:
> 
> +config MGBE
> +       tristate "Mucse(R) 1GbE PCI Express adapters support"
> +       depends on PCI
> +       select PAGE_POOL
> +       help
> +         This driver supports Mucse(R) 1GbE PCI Express family of
> +         adapters.
> 
> This is a 1G NIC, so you can remove 10G, 25G and 40G from there. They
> are pointless.
> 
> 	Andrew
> 

Got it, I will fix this.
Thanks for your feedback.