netdev - Re: [PATCH net-next v7 2/3] net: Use netif_set_threaded_hint instead of netif_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i++XK3BFzk4t4bvKeZtqXT-FUCaY_5SkSTOeV0AGNDdZg@mail.gmail.com>
Date: Tue, 22 Jul 2025 01:21:58 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Samiullah Khawaja <skhawaja@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>, 
	Paolo Abeni <pabeni@...hat.com>, almasrymina@...gle.com, willemb@...gle.com, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v7 2/3] net: Use netif_set_threaded_hint instead
 of netif_set_threaded in drivers

On Mon, Jul 21, 2025 at 8:07 PM Samiullah Khawaja <skhawaja@...gle.com> wrote:
>
> Prepare for adding an enum type for NAPI threaded states by adding
> netif_set_threaded_hint API. De-export the existing netif_set_threaded API
> and only use it internally. Update existing drivers to use
> netif_set_threaded_hint instead of the de-exported netif_set_threaded.
>
> Note that dev_set_threaded used by mt76 debugfs file is unchanged.
>
> Signed-off-by: Samiullah Khawaja <skhawaja@...gle.com>
> ---
> v7:
>  - Rebased and resolved conflicts.
>
> ---
>  drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
>  drivers/net/ethernet/mellanox/mlxsw/pci.c       | 2 +-
>  drivers/net/ethernet/renesas/ravb_main.c        | 2 +-
>  drivers/net/wireguard/device.c                  | 2 +-
>  drivers/net/wireless/ath/ath10k/snoc.c          | 2 +-
>  include/linux/netdevice.h                       | 2 +-
>  net/core/dev.c                                  | 7 ++++++-
>  net/core/dev.h                                  | 2 ++
>  8 files changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 3a9ad4a9c1cb..ee7d07c86dcf 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -2688,7 +2688,7 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>         adapter->mii.mdio_write = atl1c_mdio_write;
>         adapter->mii.phy_id_mask = 0x1f;
>         adapter->mii.reg_num_mask = MDIO_CTRL_REG_MASK;
> -       netif_set_threaded(netdev, true);
> +       netif_set_threaded_hint(netdev);

I have not seen a cover letter for this series ?

netif_set_threaded_hint() name seems a bit strange, it seems drivers
intent is to enable threaded mode ?

netif_threaded_enable() might be a better name.