netdev - Re: [PATCH net] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250723143141.dnhct6w22uzi7ufk@skbuf>
Date: Wed, 23 Jul 2025 17:31:41 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: maher azz <maherazz04@...il.com>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	Ferenc Fejes <fejes@....elte.hu>
Subject: Re: [PATCH net] net/sched: mqprio: fix stack out-of-bounds write in
 tc entry parsing

Hi Maher,

On Wed, Jul 23, 2025 at 02:01:52PM +0100, maher azz wrote:
> Hello,
> 
> Thank you for taking the time to look into it. Should I remove the
> “reported by” tag? resend another patch or is it fine like that?
> 
> Best regards,
> Maher

For an initial patch submission, the quality is reasonable. But it needs
improvement before it can be merged, and I recommend submitting a v2, no
earlier than 24 hours after the initial submission.

Some comments:

1. The "Author:" (in git; in the email it is the "From:" field) and last
   "Signed-off-by:" tag need to coincide. In your case, they point to
   the same person (you), but the formatting is different, so they don't
   coincide. Please fix your "git config --global user.name" in the way
   that Simon indicated.
2. Please don't top-post. Trim the quoted email to just the relevant
   portions you're responding to, and respond below the quoted email.
3. Please configure your email client to respond only using plain-text
   emails, no HTML.