netdev - Re: [net PatchV3] Octeontx2-vf: Fix max packet length errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIEYe/lXNAsvv24l@test-OptiPlex-Tower-Plus-7010>
Date: Wed, 23 Jul 2025 22:44:35 +0530
From: Hariprasad Kelam <hkelam@...vell.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Sunil Goutham
	<sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        "Subbaraya
 Sundeep" <sbhatta@...vell.com>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        "Andrew Lunn" <andrew+netdev@...n.ch>,
        "David S. Miller"
	<davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Tomasz Duszynski
	<tduszynski@...vell.com>,
        Simon Horman <horms@...nel.org>
Subject: Re: [net PatchV3] Octeontx2-vf: Fix max packet length errors

On 2025-07-21 at 19:28:05, Andrew Lunn (andrew@...n.ch) wrote:
> On Mon, Jul 21, 2025 at 02:28:15PM +0530, Hariprasad Kelam wrote:
> > Implement packet length validation before submitting packets to
> > the hardware to prevent MAXLEN_ERR. Increment tx_dropped counter
> > on failure.
> 
> Sorry, i did not look at previous versions of this patch, so i might
> be asking a question some other Reviewer already asked.
> 
> How expensive is MAXLEN_ERR? What do you need to do when it happens?
>
  On error case, hardware raises the queue interrupts about max lenth errors 
  goes to hang state. Driver needs to execute reset to come out of the state.

 
> I would _guess_ that if ndev->mtu is set correctly, and any change to
> it validated, you are going to get very few packets which are too big.
> 
> Is it better to introduce this test on the hot path which effects
> every single packet, or just deal with MAXLEN_ERR if it ever actually
> happens, so leaving the hot path optimised for the common case?
> 
> Maybe you could include something about this in the commit message?
>
 ACK will update the commit description. 
> 	Andrew
>