netdev - Re: [PATCH v2] usbnet: Set duplex status to unknown in the absence of MII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afdfb8e8-0d42-4b5c-86fa-e46fed35b80f@suse.com>
Date: Thu, 24 Jul 2025 11:03:57 +0200
From: Oliver Neukum <oneukum@...e.com>
To: yicongsrfy@....com, kuba@...nel.org, andrew+netdev@...n.ch,
 andrew@...n.ch, oneukum@...e.com
Cc: davem@...emloft.net, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
 yicong@...inos.cn
Subject: Re: [PATCH v2] usbnet: Set duplex status to unknown in the absence of
 MII

On 24.07.25 03:31, yicongsrfy@....com wrote:
> From: Yi Cong <yicong@...inos.cn>
> 
> Currently, USB CDC devices that do not use MDIO to get link status have
> their duplex mode set to half-duplex by default. However, since the CDC
> specification does not define a duplex status, this can be misleading.
> 
> This patch changes the default to DUPLEX_UNKNOWN in the absence of MII,
> which more accurately reflects the state of the link and avoids implying
> an incorrect or error state.
> 
> v2: rewrote commmit messages and code comments
> 
> Link: https://lore.kernel.org/all/20250723152151.70a8034b@kernel.org/
> Signed-off-by: Yi Cong <yicong@...inos.cn>
Acked-by: Oliver Neukum <oneukum@...e.com>