netdev - Re: [PATCH 3/6 net-next] net: Convert proto_ops bind() callbacks to use sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202507241955.LuEWrXAU-lkp@intel.com>
Date: Thu, 24 Jul 2025 19:29:15 +0800
From: kernel test robot <lkp@...el.com>
To: Kees Cook <kees@...nel.org>, Jakub Kicinski <kuba@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Kees Cook <kees@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/6 net-next] net: Convert proto_ops bind() callbacks to
 use sockaddr_unspec

Hi Kees,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20250723]
[also build test WARNING on v6.16-rc7]
[cannot apply to net-next/main bluetooth-next/master bluetooth/master brauner-vfs/vfs.all mkl-can-next/testing mptcp/export mptcp/export-net trondmy-nfs/linux-next linus/master v6.16-rc7 v6.16-rc6 v6.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/net-uapi-Add-__kernel_sockaddr_unspec-for-sockaddr-of-unknown-length/20250724-072218
base:   next-20250723
patch link:    https://lore.kernel.org/r/20250723231921.2293685-3-kees%40kernel.org
patch subject: [PATCH 3/6 net-next] net: Convert proto_ops bind() callbacks to use sockaddr_unspec
config: x86_64-buildonly-randconfig-003-20250724 (https://download.01.org/0day-ci/archive/20250724/202507241955.LuEWrXAU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250724/202507241955.LuEWrXAU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507241955.LuEWrXAU-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/packet/af_packet.c: In function 'packet_bind_spkt':
   net/packet/af_packet.c:3340:33: error: 'struct __kernel_sockaddr_unspec' has no member named 'sa_data_min'; did you mean 'sa_data'?
    3340 |         char name[sizeof(uaddr->sa_data_min) + 1];
         |                                 ^~~~~~~~~~~
         |                                 sa_data
   net/packet/af_packet.c:3351:52: error: 'struct __kernel_sockaddr_unspec' has no member named 'sa_data_min'; did you mean 'sa_data'?
    3351 |         memcpy(name, uaddr->sa_data, sizeof(uaddr->sa_data_min));
         |                                                    ^~~~~~~~~~~
         |                                                    sa_data
   net/packet/af_packet.c:3352:28: error: 'struct __kernel_sockaddr_unspec' has no member named 'sa_data_min'; did you mean 'sa_data'?
    3352 |         name[sizeof(uaddr->sa_data_min)] = 0;
         |                            ^~~~~~~~~~~
         |                            sa_data
>> net/packet/af_packet.c:3340:14: warning: unused variable 'name' [-Wunused-variable]
    3340 |         char name[sizeof(uaddr->sa_data_min) + 1];
         |              ^~~~
>> net/packet/af_packet.c:3355:1: warning: control reaches end of non-void function [-Wreturn-type]
    3355 | }
         | ^


vim +/name +3340 net/packet/af_packet.c

^1da177e4c3f41 Linus Torvalds      2005-04-16  3331  
^1da177e4c3f41 Linus Torvalds      2005-04-16  3332  /*
^1da177e4c3f41 Linus Torvalds      2005-04-16  3333   *	Bind a packet socket to a device
^1da177e4c3f41 Linus Torvalds      2005-04-16  3334   */
^1da177e4c3f41 Linus Torvalds      2005-04-16  3335  
40570133fbb3ba Kees Cook           2025-07-23  3336  static int packet_bind_spkt(struct socket *sock, struct sockaddr_unspec *uaddr,
40d4e3dfc2f56a Eric Dumazet        2009-07-21  3337  			    int addr_len)
^1da177e4c3f41 Linus Torvalds      2005-04-16  3338  {
^1da177e4c3f41 Linus Torvalds      2005-04-16  3339  	struct sock *sk = sock->sk;
b5f0de6df6dce8 Kees Cook           2022-10-18 @3340  	char name[sizeof(uaddr->sa_data_min) + 1];
^1da177e4c3f41 Linus Torvalds      2005-04-16  3341  
^1da177e4c3f41 Linus Torvalds      2005-04-16  3342  	/*
^1da177e4c3f41 Linus Torvalds      2005-04-16  3343  	 *	Check legality
^1da177e4c3f41 Linus Torvalds      2005-04-16  3344  	 */
^1da177e4c3f41 Linus Torvalds      2005-04-16  3345  
^1da177e4c3f41 Linus Torvalds      2005-04-16  3346  	if (addr_len != sizeof(struct sockaddr))
^1da177e4c3f41 Linus Torvalds      2005-04-16  3347  		return -EINVAL;
540e2894f79055 Alexander Potapenko 2017-03-01  3348  	/* uaddr->sa_data comes from the userspace, it's not guaranteed to be
540e2894f79055 Alexander Potapenko 2017-03-01  3349  	 * zero-terminated.
540e2894f79055 Alexander Potapenko 2017-03-01  3350  	 */
b5f0de6df6dce8 Kees Cook           2022-10-18  3351  	memcpy(name, uaddr->sa_data, sizeof(uaddr->sa_data_min));
b5f0de6df6dce8 Kees Cook           2022-10-18  3352  	name[sizeof(uaddr->sa_data_min)] = 0;
^1da177e4c3f41 Linus Torvalds      2005-04-16  3353  
6ffc57ea004234 Eric Dumazet        2023-05-26  3354  	return packet_do_bind(sk, name, 0, 0);
^1da177e4c3f41 Linus Torvalds      2005-04-16 @3355  }
^1da177e4c3f41 Linus Torvalds      2005-04-16  3356  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki