netdev - Re: [PATCH 1/3] xfrm: hold device only for the asynchronous decryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e49ee3e-bd77-410b-b367-d16e688d8a40@redhat.com>
Date: Thu, 24 Jul 2025 15:18:12 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Steffen Klassert <steffen.klassert@...unet.com>,
 David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] xfrm: hold device only for the asynchronous
 decryption

On 7/23/25 10:03 AM, Steffen Klassert wrote:
> @@ -649,18 +650,18 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
>  		XFRM_SKB_CB(skb)->seq.input.low = seq;
>  		XFRM_SKB_CB(skb)->seq.input.hi = seq_hi;
>  
> -		dev_hold(skb->dev);
> -
> -		if (crypto_done)
> +		if (crypto_done) {
>  			nexthdr = x->type_offload->input_tail(x, skb);
> -		else
> +		} else {
> +			dev_hold(skb->dev);

Side note for a possible follow-up: plain dev_hold()/dev_put() usage
should be replaced by the tracker-enabled variant
(netdev_hold()/netdev_put())

/P