netdev - Re: [PATCH 3/6 net-next] net: Convert proto_ops bind() callbacks to use sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2B9D5F9B-2AAD-4578-B87F-3ADD67EDA6BF@kernel.org>
Date: Thu, 24 Jul 2025 06:31:52 -0700
From: Kees Cook <kees@...nel.org>
To: kernel test robot <lkp@...el.com>, Jakub Kicinski <kuba@...nel.org>
CC: oe-kbuild-all@...ts.linux.dev, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Willem de Bruijn <willemb@...gle.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH 3/6 net-next] net: Convert proto_ops bind() callbacks to use sockaddr_unspec



On July 24, 2025 4:29:15 AM PDT, kernel test robot <lkp@...el.com> wrote:
>Hi Kees,
>
>kernel test robot noticed the following build warnings:
>
>[auto build test WARNING on next-20250723]
>[also build test WARNING on v6.16-rc7]
>[cannot apply to net-next/main bluetooth-next/master bluetooth/master brauner-vfs/vfs.all mkl-can-next/testing mptcp/export mptcp/export-net trondmy-nfs/linux-next linus/master v6.16-rc7 v6.16-rc6 v6.16-rc5]
>[If your patch is applied to the wrong git tree, kindly drop us a note.
>And when submitting patch, we suggest to use '--base' as documented in
>https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
>url:    https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/net-uapi-Add-__kernel_sockaddr_unspec-for-sockaddr-of-unknown-length/20250724-072218
>base:   next-20250723
>patch link:    https://lore.kernel.org/r/20250723231921.2293685-3-kees%40kernel.org
>patch subject: [PATCH 3/6 net-next] net: Convert proto_ops bind() callbacks to use sockaddr_unspec
>config: x86_64-buildonly-randconfig-003-20250724 (https://download.01.org/0day-ci/archive/20250724/202507241955.LuEWrXAU-lkp@intel.com/config)
>compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
>reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250724/202507241955.LuEWrXAU-lkp@intel.com/reproduce)
>
>If you fix the issue in a separate patch/commit (i.e. not just a new version of
>the same patch/commit), kindly add following tags
>| Reported-by: kernel test robot <lkp@...el.com>
>| Closes: https://lore.kernel.org/oe-kbuild-all/202507241955.LuEWrXAU-lkp@intel.com/
>
>All warnings (new ones prefixed by >>):
>
>   net/packet/af_packet.c: In function 'packet_bind_spkt':
>   net/packet/af_packet.c:3340:33: error: 'struct __kernel_sockaddr_unspec' has no member named 'sa_data_min'; did you mean 'sa_data'?
>    3340 |         char name[sizeof(uaddr->sa_data_min) + 1];
>         |                                 ^~~~~~~~~~~
>         |                                 sa_data
>   net/packet/af_packet.c:3351:52: error: 'struct __kernel_sockaddr_unspec' has no member named 'sa_data_min'; did you mean 'sa_data'?
>    3351 |         memcpy(name, uaddr->sa_data, sizeof(uaddr->sa_data_min));
>         |                                                    ^~~~~~~~~~~
>         |                                                    sa_data

Hmpf. My mistake -- I've been trying to send out subsets of these patches so I don't spam netdev with 100 patches and I had the "make sockaddr a fixed size" patch earlier in my larger series. I will get this adjusted and retested. I'll wait for design feedback first, though. :)


-- 
Kees Cook