netdev - Re: [PATCH net-next 3/4] net/ipv6: use ipv6_fl_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aII62Z85k7UCX-cY@eidolon.nox.tf>
Date: Thu, 24 Jul 2025 15:53:29 +0200
From: David Lamparter <equinox@...c24.net>
To: David Lamparter <equinox@...c24.net>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Lorenzo Colitti <lorenzo@...gle.com>,
	Patrick Rohr <prohr@...gle.com>
Subject: Re: [PATCH net-next 3/4] net/ipv6: use ipv6_fl_get_saddr in output

Of course I find a mistake half an hour after sending it out...

On Thu, Jul 24, 2025 at 03:18:24PM +0200, David Lamparter wrote:
> @@ -1111,31 +1111,44 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk,
>  	struct neighbour *n;
>  	struct rt6_info *rt;
>  #endif
> -	int err;
> +	int err = 0;
>  	int flags = 0;
[...]
>  		struct rt6_info *rt;
> +		bool same_vrf;
> +		int err = 0;

I accidentally introduced a second, shadow copy of "err"...

*sigh* should've built with W=2 so I get -Wshadow

...fixing and resending.


-David