netdev - Re: [Intel-wired-lan] [PATCH v7 iwl-next] ice: add recovery clock and clock 1588 control for E825c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e8c0ec4f-e448-4a91-8496-c6d4ffc3aaf2@intel.com>
Date: Thu, 24 Jul 2025 13:02:31 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>, "Nitka,
 Grzegorz" <grzegorz.nitka@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Korba, Przemyslaw"
	<przemyslaw.korba@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Olech, Milena" <milena.olech@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH v7 iwl-next] ice: add recovery clock and
 clock 1588 control for E825c



On 7/23/2025 1:17 PM, Kubalewski, Arkadiusz wrote:
>> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>> Grzegorz Nitka
>> Sent: Wednesday, July 23, 2025 12:25 AM

...

>> ---
>> v7:
>> - fix lkp error about wrong label name
>> v6:
>> - extended commit message with usage examples
>> - updated int ice_dpll_init_pins (removed E825 checker from
>>   if-condition, use ICE_DPLL_PIN_1588_NUM instead of
>>   ICE_DPLL_RCLK_NUM_PER_PF)
>> v5:
>> - fix lkp warning about ice_e825c_inputs definition
>> v4:
>> - rebased
>> - fix docstring for ice_dpll_cfg_synce_ethdiv_e825c (removed 'divider'
>>   argument)
>> v3:
>> - rebased
>> - removed netdev reference in 1588 pin initialization
>> - improved error path in ice_dpll_init_pins
>> v2:
>> - rebased, addressed comments from v1 (kdoc updated, removed unrelated
>>   code changes, fixed undefined 'ret' code in error patchs, use feature
>>   flag instead of MAC type chacking)
>> - use ptp.ptp_port to create pins indexes instead of PF ID
>> - removed CLK_OUT/output pins definitions as unused
>> - removed redundant dpll_netdev_pin_set call on 1588 pin
>> - removed checkpatch warning about SET_PIN_STATE macro (parenthesis
>>   added)
> 
> Don't think we need to keep full history, last version diff would be
> just fine.

I like to see the full history and based off the other submissions to 
the list, I assume, that's the general preference.

Thanks,
Tony