netdev - Re: [PATCH v2 05/10] can: kvaser_pciefd: Store device channel index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a88f2cfa-69e1-400e-ad67-01ae83f3f9f6@gmail.com>
Date: Thu, 24 Jul 2025 09:08:52 +0200
From: Jimmy Assarsson <jimmyassarsson@...il.com>
To: Jimmy Assarsson <extja@...ser.com>, linux-can@...r.kernel.org,
 Vincent MAILHOL <mailhol.vincent@...adoo.fr>,
 Marc Kleine-Budde <mkl@...gutronix.de>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v2 05/10] can: kvaser_pciefd: Store device channel index


On 7/24/25 8:36 AM, Jimmy Assarsson wrote:
> Store device channel index in netdev.dev_port.
> 
> Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
> Signed-off-by: Jimmy Assarsson <extja@...ser.com>
> ---
> Changes in v2:
>    - Add Fixes tag.
> 
>   drivers/net/can/kvaser_pciefd.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
> index 7153b9ea0d3d..8dcb1d1c67e4 100644
> --- a/drivers/net/can/kvaser_pciefd.c
> +++ b/drivers/net/can/kvaser_pciefd.c
> @@ -1028,6 +1028,7 @@ static int kvaser_pciefd_setup_can_ctrls(struct kvaser_pciefd *pcie)
>   		can->completed_tx_bytes = 0;
>   		can->bec.txerr = 0;
>   		can->bec.rxerr = 0;
> +		can->can.dev->dev_port = i;
>   
>   		init_completion(&can->start_comp);
>   		init_completion(&can->flush_comp);

Would it be better to submit this as a separate patch, or keep it within
this patch series?

Best regards,
jimmy