netdev - RE: [PATCH net-next v2 2/3] net: wangxun: limit tx_max_coalesced_frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <046601dbfc6e$41017be0$c30473a0$@trustnetic.com>
Date: Thu, 24 Jul 2025 15:40:40 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Jacob Keller'" <jacob.e.keller@...el.com>,
	<netdev@...r.kernel.org>,
	"'Andrew Lunn'" <andrew+netdev@...n.ch>,
	"'David S. Miller'" <davem@...emloft.net>,
	"'Eric Dumazet'" <edumazet@...gle.com>,
	"'Jakub Kicinski'" <kuba@...nel.org>,
	"'Paolo Abeni'" <pabeni@...hat.com>,
	"'Simon Horman'" <horms@...nel.org>
Cc: "'Mengyuan Lou'" <mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v2 2/3] net: wangxun: limit tx_max_coalesced_frames_irq

On Tue, Jul 22, 2025 7:57 AM, Jacob Keller wrote:
> On 7/21/2025 1:01 AM, Jiawen Wu wrote:
> > Add limitation on tx_max_coalesced_frames_irq as 0 ~ 65535.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> > ---
> 
> Previously you accepted arbitrary values, and now its limited to the
> specified range of 0 through 65535. Seems reasonable. Might be good to
> explain why this particular limit is chosen.

Because 'wx->tx_work_limit' is a u16 member.

> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> >  drivers/net/ethernet/wangxun/libwx/wx_ethtool.c | 7 +++++--
> >  drivers/net/ethernet/wangxun/libwx/wx_type.h    | 1 +
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> > index 85fb23b238d1..ebef99185bca 100644
> > --- a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> > +++ b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> > @@ -334,8 +334,11 @@ int wx_set_coalesce(struct net_device *netdev,
> >  			return -EOPNOTSUPP;
> >  	}
> >
> > -	if (ec->tx_max_coalesced_frames_irq)
> > -		wx->tx_work_limit = ec->tx_max_coalesced_frames_irq;
> > +	if (ec->tx_max_coalesced_frames_irq > WX_MAX_TX_WORK ||
> > +	    !ec->tx_max_coalesced_frames_irq)
> > +		return -EINVAL;
> > +
> > +	wx->tx_work_limit = ec->tx_max_coalesced_frames_irq;
> >
> >  	switch (wx->mac.type) {
> >  	case wx_mac_sp:
> > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> > index 9d5d10f9e410..5c52a1db4024 100644
> > --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h
> > +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> > @@ -411,6 +411,7 @@ enum WX_MSCA_CMD_value {
> >  #define WX_7K_ITR                    595
> >  #define WX_12K_ITR                   336
> >  #define WX_20K_ITR                   200
> > +#define WX_MAX_TX_WORK               65535
> >  #define WX_SP_MAX_EITR               0x00000FF8U
> >  #define WX_AML_MAX_EITR              0x00000FFFU
> >  #define WX_EM_MAX_EITR               0x00007FFCU