netdev - Re: [PATCH wireless-next] wifi: mac80211: fix use-after-free risk in sta debugfs removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF3JpA5vCOK72Ojy4FTa_MVGz=yYnJ5=vd8x6prMiC7UxBGWuQ@mail.gmail.com>
Date: Thu, 24 Jul 2025 00:48:56 -0700
From: Moon Hee Lee <moonhee.lee.ca@...il.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev, netdev@...r.kernel.org, 
	syzkaller-bugs@...glegroups.com, 
	syzbot+d6ccd49ae046542a0641@...kaller.appspotmail.com, 
	skhan@...uxfoundation.org, david.hunter.linux@...il.com
Subject: Re: [PATCH wireless-next] wifi: mac80211: fix use-after-free risk in
 sta debugfs removal

On Thu, Jul 24, 2025 at 12:18 AM Johannes Berg
<johannes@...solutions.net> wrote:
> Maybe so, but it really looks like a bandaid?! Why are we trying to
> remove it twice in the first place?

Thanks, Johannes. I agree this patch is only defensive and does not
address the root cause.

I am currently tracing the sta_info_destroy flow to determine whether
this is caused by a duplicate free or an unsynchronized access to
sta->debugfs_dir. If the race is confirmed, I will follow up with a
more complete fix that properly handles the lifecycle.