netdev - Re: [PATCH v3 08/10] can: kvaser_pciefd: Expose device firmware version via devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96b9da59-bf24-460a-bccf-5761b8c2e87a@gmail.com>
Date: Fri, 25 Jul 2025 14:39:38 +0200
From: Jimmy Assarsson <jimmyassarsson@...il.com>
To: Simon Horman <horms@...nel.org>, Jimmy Assarsson <extja@...ser.com>
Cc: linux-can@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 08/10] can: kvaser_pciefd: Expose device firmware
 version via devlink info_get()

On 7/24/25 3:52 PM, Simon Horman wrote:
> On Thu, Jul 24, 2025 at 09:30:19AM +0200, Jimmy Assarsson wrote:
> 
> ...
> 
>> diff --git a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
>> index 8145d25943de..4e4550115368 100644
>> --- a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
>> +++ b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
>> @@ -4,7 +4,33 @@
>>    * Copyright (C) 2025 KVASER AB, Sweden. All rights reserved.
>>    */
>>   
>> +#include "kvaser_pciefd.h"
>> +
>>   #include <net/devlink.h>
> 
> Hi Jimmy,
> 
> Please consider squashing the two-line change above into
> the previous patch in this series to avoid the following
> transient Sparse warning.
> 
>    .../kvaser_pciefd_devlink.c:9:26: warning: symbol 'kvaser_pciefd_devlink_ops' was not declared. Should it be static?
> 
> Thanks!

Hi Simon!

Sure, I'll fix it in v4.
Thanks for reviewing!

Best regards,
jimmy