netdev - RE: [Intel-wired-lan] [PATCH net v2 4/6] idpf: replace flow scheduling buffer ring with buffer pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR11MB65026412ED88DA7433B2EE16D459A@DM4PR11MB6502.namprd11.prod.outlook.com>
Date: Fri, 25 Jul 2025 17:15:24 +0000
From: "Hay, Joshua A" <joshua.a.hay@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Luigi Rizzo
	<lrizzo@...gle.com>, Brian Vazquez <brianvv@...gle.com>, "Chittim, Madhu"
	<madhu.chittim@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net v2 4/6] idpf: replace flow
 scheduling buffer ring with buffer pool

> > @@ -1959,10 +1966,29 @@ static bool idpf_tx_clean_buf_ring(struct
> idpf_tx_queue *txq, u16 compl_tag,
> >  	};
> >  	u16 ntc, orig_idx = idx;
> >
> > +	tx_buf = &txq->tx_buf[buf_id];
> > +	if (tx_buf->type == LIBETH_SQE_SKB) {
> > +		if (skb_shinfo(tx_buf->skb)->tx_flags & SKBTX_IN_PROGRESS)
> > +			idpf_tx_read_tstamp(txq, tx_buf->skb);
> > +
> > +		libeth_tx_complete(tx_buf, &cp);
> > +		idpf_post_buf_refill(txq->refillq, buf_id);
> > +	}
> > +
> > +	while (idpf_tx_buf_next(tx_buf) != IDPF_TXBUF_NULL) {
> > +		u16 buf_id = idpf_tx_buf_next(tx_buf);
> > +
> > +		tx_buf = &txq->tx_buf[buf_id];
> > +		libeth_tx_complete(tx_buf, &cp);
> > +		idpf_post_buf_refill(txq->refillq, buf_id);
> > +	}
> > +
> > +	return true;
> 
> This is not a full review.
> And I guess this is an artifact of the development of this patch-set.

Correct, it's removed in the final patch of the series, but I can remove it in this patch instead. Will send a v3 shortly.

Thanks!
Josh 

> But the code in this function below this line appears to be unreachable.
> 
> Flagged by Smatch.
> 
> > +
> >  	tx_buf = &txq->tx_buf[idx];
> >
> >  	if (unlikely(tx_buf->type <= LIBETH_SQE_CTX ||
> > -		     idpf_tx_buf_compl_tag(tx_buf) != compl_tag))
> > +		     idpf_tx_buf_compl_tag(tx_buf) != buf_id))
> >  		return false;
> >
> >  	if (tx_buf->type == LIBETH_SQE_SKB) {
> 
> ...