netdev - Re: [PATCH net-next 13/19] netfilter: nft_set: remove one argument from lookup and update functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250725164504.2c68da9a@kernel.org>
Date: Fri, 25 Jul 2025 16:45:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: netfilter-devel@...r.kernel.org, davem@...emloft.net,
 netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com,
 fw@...len.de, horms@...nel.org
Subject: Re: [PATCH net-next 13/19] netfilter: nft_set: remove one argument
 from lookup and update functions

On Fri, 25 Jul 2025 16:37:29 -0700 Jakub Kicinski wrote:
> On Fri, 25 Jul 2025 19:03:34 +0200 Pablo Neira Ayuso wrote:
> > diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c
> > index 08fb6720673f..36a4de11995b 100644
> > --- a/net/netfilter/nft_set_pipapo.c
> > +++ b/net/netfilter/nft_set_pipapo.c
> > @@ -407,8 +407,9 @@ int pipapo_refill(unsigned long *map, unsigned int len, unsigned int rules,
> >   *
> >   * Return: true on match, false otherwise.
> >   */
> > -bool nft_pipapo_lookup(const struct net *net, const struct nft_set *set,
> > -		       const u32 *key, const struct nft_set_ext **ext)
> > +const struct nft_set_ext *
> > +nft_pipapo_lookup(const struct net *net, const struct nft_set *set,
> > +		  const u32 *key)  
> 
> Warning: ../net/netfilter/nft_set_pipapo_avx2.c:1151 Excess function parameter 'ext' description in 'nft_pipapo_avx2_lookup'
> Warning: ../net/netfilter/nft_set_pipapo.c:412 Excess function parameter 'ext' description in 'nft_pipapo_lookup'
> 
> Hopefully this doesn't bubble up to htmldocs.
> Please follow up with the fix.

Ah, I take that back, looks like the next two commits fix these.
Bad squash perhaps..