netdev - Re: [PATCH net] phy: dp83869: fix interrupts issue when using with an optical fiber sfp. to correctly clear the interrupts both status registers must be read.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33f056e7-6bf4-47be-aa8b-95640bf2151c@lunn.ch>
Date: Sat, 26 Jul 2025 17:14:20 +0200
From: Andrew Lunn <andrew@...n.ch>
To: chalianis1@...il.com
Cc: hkallweit1@...il.com, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux@...linux.org.uk, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] phy: dp83869: fix interrupts issue when using with
 an optical fiber sfp. to correctly clear the interrupts both status
 registers must be read.

On Fri, Jul 25, 2025 at 08:10:34PM -0400, chalianis1@...il.com wrote:
> From: Anis Chali <chalianis1@...il.com>
> 
> from datasheet of dp83869hm
> 7.3.6 Interrupt
> The DP83869HM can be configured to generate an interrupt when changes of internal status occur. The interrupt
> allows a MAC to act upon the status in the PHY without polling the PHY registers. The interrupt source can be
> selected through the interrupt registers, MICR (12h) and FIBER_INT_EN (C18h). The interrupt status can be
> read from ISR (13h) and FIBER_INT_STTS (C19h) registers.

Reading this description, it sounds like the fibre interrupt it not
cascaded into the micr? There are two completely different sets of
registers.

So i seems like you should be reading this register in
dp83869_handle_interrupt() same as the MICR.

    Andrew

---
pw-bot: cr