netdev - Re: [PATCH net v2 2/2] selftests/tc-testing: Check backlog stats in gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B8J1l8WROec_5SO22mW3x14RB4EaaMDgyXKYD-U_3H2vyJO0yUbD0ufDYc8vPshaBM0lLi1uTmA0TKVfXI-aANfL7gLUVx_GK_5UpPPStFc=@willsroot.io>
Date: Sat, 26 Jul 2025 16:04:33 +0000
From: William Liu <will@...lsroot.io>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, pabeni@...hat.com, kuba@...nel.org, jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com, horms@...nel.org, savy@...t3mfailure.io
Subject: Re: [PATCH net v2 2/2] selftests/tc-testing: Check backlog stats in gso_skb case

On Friday, July 25th, 2025 at 10:50 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:

> 
> 
> On Thu, Jul 24, 2025 at 04:55:53PM +0000, William Liu wrote:
> 
> > diff --git a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
> > index c6db7fa94f55..867654a31a95 100644
> > --- a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
> > +++ b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
> > @@ -185,6 +185,207 @@
> > "$IP addr del 10.10.10.10/24 dev $DUMMY || true"
> > ]
> > },
> > + {
> > + "id": "34c0",
> > + "name": "Test TBF with HHF Backlog Accounting in gso_skb case",
> > + "category": [
> > + "qdisc",
> > + "tbf",
> > + "hhf"
> > + ],
> > + "plugins": {
> > + "requires": [
> > + "nsPlugin",
> > + "scapyPlugin"
> 
> 
> scapyPlugin is not required unless you generate traffic with scapy
> instead of ping.
> 

Ok I shall update this.

> > + ]
> > + },
> > + "setup": [
> > + "$IP link set dev $DUMMY up || true",
> > + "$IP addr add 10.10.11.10/24 dev $DUMMY || true",
> > + "$TC qdisc add dev $DUMMY root handle 1: tbf rate 8bit burst 100b latency 100ms",
> > + "$TC qdisc replace dev $DUMMY handle 2: parent 1:1 hhf limit 1000",
> > + [
> > + "ping -I $DUMMY -f -c8 -s32 -W0.001 10.10.11.11",
> > + 1
> 
> 
> What is this magic number here? :)
> 
> 

That's from the original repro. I can simplify it a bit.

> Thanks.