netdev - Re: [PATCH 2/4] net: mhi : Add support to enable ethernet interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250725171053.03c0c44d@kernel.org>
Date: Fri, 25 Jul 2025 17:10:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vivek.Pernamitta@...cinc.com
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Manivannan Sadhasivam <mani@...nel.org>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>, Vivek Pernamitta
 <quic_vpernami@...cinc.com>
Subject: Re: [PATCH 2/4] net: mhi : Add support to enable ethernet interface

On Thu, 24 Jul 2025 19:21:18 +0530 Vivek.Pernamitta@...cinc.com wrote:
>  	ndev = alloc_netdev(sizeof(struct mhi_net_dev), netname,
> -			    NET_NAME_PREDICTABLE, mhi_net_setup);
> +			    NET_NAME_PREDICTABLE, info->ethernet_if ?
> +			    mhi_ethernet_setup : mhi_net_setup);

Similar story, if it's an Ethernet device is should be called eth%d
and user space can name it whatever it wants based on the full sysfs
attribute set.

For n-th time in our history we discover that having the kernel create
"predictable" names always falls short, sigh.