netdev - Re: [net-next v16 04/12] net: mtip: The L2 switch driver for imx287

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250726133835.6e28a717@kernel.org>
Date: Sat, 26 Jul 2025 13:38:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Richard Cochran
 <richardcochran@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, Stefan Wahren
 <wahrenst@....net>, Simon Horman <horms@...nel.org>, Andrew Lunn
 <andrew@...n.ch>
Subject: Re: [net-next v16 04/12] net: mtip: The L2 switch driver for imx287

On Sat, 26 Jul 2025 22:13:23 +0200 Lukasz Majewski wrote:
> > > +		ret = register_netdev(fep->ndev[i]);
> > > +		if (ret) {
> > > +			dev_err(&fep->ndev[i]->dev,
> > > +				"%s: ndev %s register err: %d\n",
> > > __func__,
> > > +				fep->ndev[i]->name, ret);
> > > +			break;
> > > +		}    
> > 
> > Error handling in case of register_netdev() still buggy, AFAICT.  
> 
> I've added the code to set fep->ndev[i] = NULL to mtip_ndev_cleanup().
> IMHO this is the correct place to add it.

If register_netdev() fails you will try to unregister it and hit 
a BUG_ON().