netdev - Re: [PATCH v3 04/11] net: qrtr: support identical node ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a42d70aa-76b8-4034-9695-2e639e6471a2@ionic.de>
Date: Sun, 27 Jul 2025 15:09:38 +0200
From: Mihai Moldovan <ionic@...ic.de>
To: Simon Horman <horms@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, Manivannan Sadhasivam <mani@...nel.org>,
 Denis Kenzior <denkenz@...il.com>, Eric Dumazet <edumazet@...gle.com>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Willem de Bruijn <willemb@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 04/11] net: qrtr: support identical node ids

* On 7/24/25 15:08, Simon Horman wrote:
> [...]

Thank you for the reviews, to both you and Jakub.

> This will leak holding qrtr_nodes_lock.

It certainly does, will be fixed in v4.

> Flagged by Smatch.

I haven't used smatch before, and probably should do so going forward.

Curiously, a simple kchecker net/qrtr/ run did not warn about the locking issue 
(albeit it being obvious in the patch), while it did warn about the second issue 
with ret. Am I missing something?

> But ret is now 0, whereas before this patch it was -EINVAL.
> This seems both to be an unintentional side effect of this patch,
> and incorrect.

True. Will also fixed in v4.

Mihai

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)