netdev - Re: [PATCH v3 04/11] net: qrtr: support identical node ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19b393bf-6ba3-406b-8b5b-48a60e5aa855@ionic.de>
Date: Sun, 27 Jul 2025 19:33:58 +0200
From: Mihai Moldovan <ionic@...ic.de>
To: Simon Horman <horms@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, Manivannan Sadhasivam <mani@...nel.org>,
 Denis Kenzior <denkenz@...il.com>, Eric Dumazet <edumazet@...gle.com>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Willem de Bruijn <willemb@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v3 04/11] net: qrtr: support identical node ids

* On 7/27/25 16:40, Simon Horman wrote:
> I tried again with the latest head,
> commit 2fb2b9093c5d ("sleep_info: The synchronize_srcu() sleeps").
> And in that case I no longer see the 1st warning, about locking.
> I think this is what you saw too.

Exactly! Together with impossible condition warnings, but those are actually 
fine/intended.

> This seems to a regression in Smatch wrt this particular case for this
> code. I bisected Smatch and it looks like it was introduced in commit
> d0367cd8a993 ("ranges: use absolute instead implied for possibly_true/false")
Oh, thank you very much. I suspected that I'm just missing a special script or 
option or even addition to Smash (given that Dan seems to have revamped its 
locking check code in 2020), especially since it seems to be so widely used in 
kernel development, but not a bug in the software itself.

Mihai

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)