netdev - Re: [PATCH] sfc: handle NULL returned by xdp_convert_buff_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4169cfd4-2231-417f-b091-d8fa2f73f176@gmail.com>
Date: Mon, 28 Jul 2025 15:28:24 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Kunwu Chan <kunwu.chan@...ux.dev>, Edward Cree <ecree@....com>,
 Paolo Abeni <pabeni@...hat.com>, Chenyuan Yang <chenyuan0y@...il.com>,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
 john.fastabend@...il.com, sdf@...ichev.me, lorenzo@...nel.org
Cc: netdev@...r.kernel.org, linux-net-drivers@....com, bpf@...r.kernel.org,
 zzjas98@...il.com
Subject: Re: [PATCH] sfc: handle NULL returned by xdp_convert_buff_to_frame()

On 25/07/2025 13:38, Kunwu Chan wrote:
> Proposed refinement:
...
>          if (net_ratelimit())
>              netif_err(efx, rx_err, efx->net_dev,
> -                  "XDP TX failed (%d)\n", err);
> +                  "XDP TX failed (%d)%s\n", err,
> +                  err == -ENOBUFS ? " [frame conversion]" : "");

Unnecessary, since efx_xdp_tx_buffers() never returns ENOBUFS.

>          channel->n_rx_xdp_bad_drops++;
> -        trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act);
> +        if (err != -ENOBUFS)
> +            trace_xdp_exception(efx->net_dev, xdp_prog, xdp_act);

Why prevent the tracepoint in this case??