netdev - Re: [PATCH v7 09/11] pmdomain: imx93-blk-ctrl: use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIeLA6lQkVxPcRyj@lizhi-Precision-Tower-5810>
Date: Mon, 28 Jul 2025 10:36:51 -0400
From: Frank Li <Frank.li@....com>
To: Joy Zou <joy.zou@....com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, peng.fan@....com, richardcochran@...il.com,
	catalin.marinas@....com, will@...nel.org, ulf.hansson@...aro.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com,
	alexandre.torgue@...s.st.com, frieder.schrempf@...tron.de,
	primoz.fiser@...ik.com, othacehe@....org,
	Markus.Niebel@...tq-group.com, alexander.stein@...tq-group.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux@...tq-group.com, netdev@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v7 09/11] pmdomain: imx93-blk-ctrl: use ARRAY_SIZE()
 instead of hardcode number

On Mon, Jul 28, 2025 at 03:14:36PM +0800, Joy Zou wrote:
> Optimize i.MX93 num_clks hardcode with ARRAY_SIZE().
>
> Signed-off-by: Joy Zou <joy.zou@....com>

Reviewed-by: Frank Li <Frank.Li@....com>
> ---
> Changes for v7:
> 1. Add new patch in order to optimize i.MX93 num_clks hardcode
>    with ARRAY_SIZE().
> ---
>  drivers/pmdomain/imx/imx93-blk-ctrl.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/imx/imx93-blk-ctrl.c b/drivers/pmdomain/imx/imx93-blk-ctrl.c
> index 0e2ba8ec55d7..1dcb84593e01 100644
> --- a/drivers/pmdomain/imx/imx93-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx93-blk-ctrl.c
> @@ -418,11 +418,15 @@ static const struct regmap_access_table imx93_media_blk_ctl_access_table = {
>  	.n_yes_ranges = ARRAY_SIZE(imx93_media_blk_ctl_yes_ranges),
>  };
>
> +static const char * const media_blk_clk_names[] = {
> +	"axi", "apb", "nic"
> +};
> +
>  static const struct imx93_blk_ctrl_data imx93_media_blk_ctl_dev_data = {
>  	.domains = imx93_media_blk_ctl_domain_data,
>  	.num_domains = ARRAY_SIZE(imx93_media_blk_ctl_domain_data),
> -	.clk_names = (const char *[]){ "axi", "apb", "nic", },
> -	.num_clks = 3,
> +	.clk_names = media_blk_clk_names,
> +	.num_clks = ARRAY_SIZE(media_blk_clk_names),
>  	.reg_access_table = &imx93_media_blk_ctl_access_table,
>  };
>
> --
> 2.37.1
>