netdev - Re: [PATCH net-next v1] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdW9tWObJgHH5g5q9fhoyV4LmHweLq2y2TEOuK34xyFfdA@mail.gmail.com>
Date: Mon, 28 Jul 2025 17:19:16 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Wen Gu <guwen@...ux.alibaba.com>, 
	Philo Lu <lulie@...ux.alibaba.com>, Lorenzo Bianconi <lorenzo@...nel.org>, 
	Lukas Bulwahn <lukas.bulwahn@...hat.com>, 
	Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v1] eea: Add basic driver framework for Alibaba
 Elastic Ethernet Adaptor

Hi Xuan,

On Thu, 24 Jul 2025 at 13:06, Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
> Add a driver framework for EEA that will be available in the future.
>
> Reviewed-by: Dust Li <dust.li@...ux.alibaba.com>
> Reviewed-by: Philo Lu <lulie@...ux.alibaba.com>
> Signed-off-by: Wen Gu <guwen@...ux.alibaba.com>
> Signed-off-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>

Thanks for your patch!

> --- /dev/null
> +++ b/drivers/net/ethernet/alibaba/Kconfig
> @@ -0,0 +1,29 @@
> +#
> +# Alibaba network device configuration
> +#
> +
> +config NET_VENDOR_ALIBABA
> +       bool "Alibaba Devices"
> +       default y
> +       help
> +         If you have a network (Ethernet) device belonging to this class, say Y.
> +
> +         Note that the answer to this question doesn't directly affect the
> +         kernel: saying N will just cause the configurator to skip all
> +         the questions about Alibaba devices. If you say Y, you will be asked
> +         for your specific device in the following questions.
> +
> +if NET_VENDOR_ALIBABA
> +
> +config EEA
> +       tristate "Alibaba Elastic Ethernet Adaptor support"
> +       depends on PCI_MSI
> +       depends on 64BIT

Any specific reason to depend on 64BIT?

> +       select PAGE_POOL
> +       default m

Drivers should be disabled by default, unless you have a very good
reason to do otherwise.

> +       help
> +         This driver supports Alibaba Elastic Ethernet Adaptor"
> +
> +         To compile this driver as a module, choose M here.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds