netdev - Re: [PATCH net-next 5/8] libie: add adminq helper for converting err to str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIch76xAiGUWd2/b@mev-dev.igk.intel.com>
Date: Mon, 28 Jul 2025 09:08:31 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
	pabeni@...hat.com, edumazet@...gle.com, andrew+netdev@...n.ch,
	netdev@...r.kernel.org,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	aleksander.lobakin@...el.com, przemyslaw.kitszel@...el.com,
	piotr.kwapulinski@...el.com, aleksandr.loktionov@...el.com,
	jedrzej.jagielski@...el.com, larysa.zaremba@...el.com
Subject: Re: [PATCH net-next 5/8] libie: add adminq helper for converting err
 to str

On Fri, Jul 25, 2025 at 04:09:30PM -0700, Jakub Kicinski wrote:
> On Thu, 24 Jul 2025 11:28:21 -0700 Tony Nguyen wrote:
> > +const char *libie_aq_str(enum libie_aq_err err)
> > +{
> > +	if (err >= ARRAY_SIZE(libie_aq_str_arr) ||
> > +	    !libie_aq_str_arr[err])
> > +		err = __LIBIE_AQ_STR_NUM;
> > +
> > +	return libie_aq_str_arr[err];
> 
> All the LIBIE error values map to the POSIX ones, right? And this is
> mostly used in error messages. So why not use %pe I wonder..

Hi,

unfortunately no, not all values are mapped correctly (I don't know why,
just FW thing probably :( ).