netdev - Re: [PATCH] net: atlantic: fix overwritten return value in Aquantia driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c42fc24b-2cd5-4598-a4bf-b088325c3d14@lunn.ch>
Date: Mon, 28 Jul 2025 04:49:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Tian <27392025k@...il.com>
Cc: irusskikh@...vell.com, netdev@...r.kernel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: atlantic: fix overwritten return value in Aquantia
 driver

On Sun, Jul 27, 2025 at 04:17:50PM -0700, Tian wrote:
> From: tian <27392025k@...il.com>
> 
> In hw_atl_utils.c and hw_atl_utils_fw2x.c, a return value is set and then
> immediately overwritten by another call, which causes the original result
> to be lost. This may hide errors that should be returned to the caller.
> 
> This patch fixes the logic to preserve the intended return values.

Please include in the commit message why it is safe to OR together two
error codes.

	Andrew