netdev - RE: [Intel-wired-lan] [PATCH iwl-net v3 6/6] idpf: remove obsolete stashing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986D19B550C24FC8D6E76E1E55AA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 28 Jul 2025 09:04:29 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Hay, Joshua A" <joshua.a.hay@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Hay, Joshua A"
	<joshua.a.hay@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v3 6/6] idpf: remove obsolete
 stashing code



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Joshua Hay
> Sent: Friday, July 25, 2025 8:42 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Hay, Joshua A <joshua.a.hay@...el.com>;
> Chittim, Madhu <madhu.chittim@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v3 6/6] idpf: remove
> obsolete stashing code
> 
> With the new Tx buffer management scheme, there is no need for all of
> the stashing mechanisms, the hash table, the reserve buffer stack,
> etc.
> Remove all of that.
> 
> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> Reviewed-by: Madhu Chittim <madhu.chittim@...el.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> ---
> v3: update comment format
> ---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c | 314 ++-----------------
> -  drivers/net/ethernet/intel/idpf/idpf_txrx.h |  47 +--
>  2 files changed, 22 insertions(+), 339 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index 6563d5831a23..a12cfad566a7 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -8,48 +8,12 @@
>  #include "idpf_ptp.h"
>  #include "idpf_virtchnl.h"
> 
> -struct idpf_tx_stash {
> -	struct hlist_node hlist;
> -	struct libeth_sqe buf;
> -};
> -
>  #define idpf_tx_buf_next(buf)		(*(u32 *)&(buf)->priv)
> -#define idpf_tx_buf_compl_tag(buf)	(*(u32 *)&(buf)->priv)
>  LIBETH_SQE_CHECK_PRIV(u32);

...

> @@ -932,7 +888,6 @@ struct idpf_txq_group {
> 
>  	u16 num_txq;
>  	struct idpf_tx_queue *txqs[IDPF_LARGE_MAX_Q];
> -	struct idpf_txq_stash *stashes;
> 
>  	struct idpf_compl_queue *complq;
> 
> --
> 2.39.2