netdev - Re: [PATCH] net: Fix typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08deec62-e20a-4a54-a655-38a0335a74cd@gmail.com>
Date: Mon, 28 Jul 2025 14:19:41 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] net: Fix typos

On 23/07/2025 21:15, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Fix typos in comments and error messages.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Sorry I wasn't able to get to this in time (had email issues last week).

> diff --git a/drivers/net/ethernet/sfc/mcdi_pcol.h b/drivers/net/ethernet/sfc/mcdi_pcol.h
> index 9cb339c461fb..b9866e389e6d 100644
> --- a/drivers/net/ethernet/sfc/mcdi_pcol.h
> +++ b/drivers/net/ethernet/sfc/mcdi_pcol.h

mcdi_pcol.h is automatically generated from an external source (it comes
 from the firmware development team), these fixes will likely be
 overwritten next time we pull in updates.  I will try to get them fed
 back into the upstream sources.

> diff --git a/drivers/net/ethernet/sfc/tc_encap_actions.c b/drivers/net/ethernet/sfc/tc_encap_actions.c
> index 87443f9dfd22..2258f854e5be 100644
> --- a/drivers/net/ethernet/sfc/tc_encap_actions.c
> +++ b/drivers/net/ethernet/sfc/tc_encap_actions.c
> @@ -442,7 +442,7 @@ static void efx_tc_update_encap(struct efx_nic *efx,
>  			rule = container_of(acts, struct efx_tc_flow_rule, acts);
>  			if (rule->fallback)
>  				fallback = rule->fallback;
> -			else /* fallback fallback: deliver to PF */
> +			else /* fallback: deliver to PF */
>  				fallback = &efx->tc->facts.pf;
>  			rc = efx_mae_update_rule(efx, fallback->fw_id,
>  						 rule->fw_id);

This wording was intentional, not a type: delivery to the PF is the
 second-layer fallback when there is no fallback action, which makes it
 the fallback to the fallback.
I will post a partial revert to change this line back.