netdev - Re: [PATCH iproute2-next] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250729112340.GB15902@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Tue, 29 Jul 2025 04:23:40 -0700
From: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
To: David Ahern <dsahern@...il.com>
Cc: stephen@...workplumber.org, netdev@...r.kernel.org,
	haiyangz@...rosoft.com, shradhagupta@...ux.microsoft.com,
	ssengar@...rosoft.com, ernis@...rosoft.com
Subject: Re: [PATCH iproute2-next] iproute2: Add 'netshaper' command to 'ip
 link' for netdev shaping

On Mon, Jul 28, 2025 at 12:15:19PM -0600, David Ahern wrote:
> On 7/28/25 3:14 AM, Erni Sri Satya Vennela wrote:
> > Add support for the netshaper Generic Netlink
> > family to iproute2. Introduce a new subcommand to `ip link` for
> > configuring netshaper parameters directly from userspace.
> > 
> > This interface allows users to set shaping attributes (such as speed)
> > which are passed to the kernel to perform the corresponding netshaper
> > operation.
> > 
> > Example usage:
> > $ip link netshaper { set | get | delete } dev DEVNAME \
> >                    handle scope SCOPE id ID \
> >                    [ speed SPEED ]
> > 
> > Internally, this triggers a kernel call to apply the shaping
> > configuration to the specified network device.
> > 
> > Currently, the tool supports the following functionalities:
> > - Setting speed in Mbps, enabling bandwidth clamping for
> >   a network device that support netshaper operations.
> > - Deleting the current configuration.
> > - Querying the existing configuration.
> > 
> > Additional netshaper operations will be integrated into the tool
> > as per requirement.
> > 
> > This change enables easy and scriptable configuration of bandwidth
> > shaping for  devices that use the netshaper Netlink family.
> > 
> > Corresponding net-next patches:
> > 1) https://lore.kernel.org/all/cover.1728460186.git.pabeni@redhat.com/
> > 2) https://lore.kernel.org/lkml/1750144656-2021-1-git-send-email-ernis@linux.microsoft.com/
> > 
> > Signed-off-by: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> > ---
> >  include/uapi/linux/netshaper.h |  92 +++++++++++++++++
> 
> the file in the kernel tree is net_shaper.h? drop it from the patch and
> ask for it to be added to the uapi files when posting the next version.
Yes, netshaper.h is same uapi file as net_shaper.h in kernel tree.
I'll remove this file in my next version.

Shall I mention about adding this file below the Signed-off-by section
in the commit message or create a patch seperately for this file?

Thankyou.