netdev - Re: [PATCH ipsec 2/3] Revert "xfrm: Remove unneeded device check from validate_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d307bb5f84cdc4bb2cbd24b27dc00969eabe86e.camel@nvidia.com>
Date: Tue, 29 Jul 2025 15:27:39 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "sd@...asysnail.net"
	<sd@...asysnail.net>
CC: Leon Romanovsky <leonro@...dia.com>, "razor@...ckwall.org"
	<razor@...ckwall.org>, "steffen.klassert@...unet.com"
	<steffen.klassert@...unet.com>
Subject: Re: [PATCH ipsec 2/3] Revert "xfrm: Remove unneeded device check from
 validate_xmit_xfrm"

On Mon, 2025-07-28 at 17:17 +0200, Sabrina Dubroca wrote:
> This reverts commit d53dda291bbd993a29b84d358d282076e3d01506.
> 
> This change causes traffic using GSO with SW crypto running through a
> NIC capable of HW offload to no longer get segmented during
> validate_xmit_xfrm.
> 
> Fixes: d53dda291bbd ("xfrm: Remove unneeded device check from
> validate_xmit_xfrm")
> 

Thanks for the fix, but I'm curious about details.

In that commit, I tried to map all of the possible code paths. Can you
please explain what code paths I missed that need real_dev given that
only bonding should use it now?

Thanks,
Cosmin.