netdev - Re: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izPonS7WbDF4BpX=CQ8kFfqjfSnXMsrrS6ivyPQpQqqs7Q@mail.gmail.com>
Date: Tue, 29 Jul 2025 08:35:56 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Byungchul Park <byungchul@...com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel_team@...ynix.com, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, hawk@...nel.org, 
	toke@...hat.com, asml.silence@...il.com
Subject: Re: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to_nmdesc()

On Tue, Jul 29, 2025 at 3:42 AM Byungchul Park <byungchul@...com> wrote:
>
> Changes from RFC:
>         1. Optimize the implementation of netmem_to_nmdesc to use less
>            instructions (feedbacked by Pavel)
>
> ---8<---
> From 6a0dbaecbf9a2425afe73565914eaa762c5d15c8 Mon Sep 17 00:00:00 2001
> From: Byungchul Park <byungchul@...com>
> Date: Tue, 29 Jul 2025 19:34:12 +0900
> Subject: [RFC net-next v2] netmem: replace __netmem_clear_lsb() with netmem_to_nmdesc()
>
> Now that we have struct netmem_desc, it'd better access the pp fields
> via struct netmem_desc rather than struct net_iov.
>
> Introduce netmem_to_nmdesc() for safely converting netmem_ref to
> netmem_desc regardless of the type underneath e.i. netmem_desc, net_iov.
>
> While at it, remove __netmem_clear_lsb() and make netmem_to_nmdesc()
> used instead.
>
> Suggested-by: Pavel Begunkov <asml.silence@...il.com>
> Signed-off-by: Byungchul Park <byungchul@...com>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

Thanks for cleaning this up. This bit of tech debt was bothering me!

-- 
Thanks,
Mina