netdev - Re: [RFC PATCH] ethtool: add FEC bins histogramm report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c52af63b-1350-4574-874e-7d6c41bc615d@lunn.ch>
Date: Tue, 29 Jul 2025 19:31:20 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Michael Chan <michael.chan@...adcom.com>,
	Pavan Chebbi <pavan.chebbi@...adcom.com>,
	Tariq Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>,
	intel-wired-lan@...ts.osuosl.org,
	Donald Hunter <donald.hunter@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] ethtool: add FEC bins histogramm report

> The only one bin will have negative value is the one to signal the end
> of the list of the bins, which is not actually put into netlink message.
> It actually better to change spec to have unsigned values, I believe.

Can any of these NICs send runt packets? Can any send packets without
an ethernet header and FCS?

Seems to me, the bin (0,0) is meaningless, so can could be considered
the end marker. You then have unsigned everywhere, keeping it KISS.

	Andrew