netdev - Re: [PATCH] vhost: initialize vq->nheads properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c236b8ef-b899-4c23-bded-cf411c5b5ad1@linux.intel.com>
Date: Tue, 29 Jul 2025 10:09:21 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: Jason Wang <jasowang@...hat.com>, mst@...hat.com, eperezma@...hat.com
Cc: kvm@...r.kernel.org, virtualization@...ts.linux.dev,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, sgarzare@...hat.com,
 will@...nel.org, JAEHOON KIM <jhkim@...ux.ibm.com>,
 Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH] vhost: initialize vq->nheads properly

On 2025-07-29 9:39 AM, Jason Wang wrote:
> Commit 7918bb2d19c9 ("vhost: basic in order support") introduces
> vq->nheads to store the number of batched used buffers per used elem
> but it forgets to initialize the vq->nheads to NULL in
> vhost_dev_init() this will cause kfree() that would try to free it
> without be allocated if SET_OWNER is not called.

nit: as someone who is not familiar with vhost code, it took me a while 
to figure out you meant VHOST_SET_OWNER and the corresponding 
vhost_dev_set_owner()

> 
> Reported-by: JAEHOON KIM <jhkim@...ux.ibm.com>
> Reported-by: Breno Leitao <leitao@...ian.org>
> Fixes: 7918bb2d19c9 ("vhost: basic in order support")
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Reviewed-by: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>

Thanks,
Dawid