netdev - Re: [PATCH net] eth: fbnic: unlink NAPIs from queues on error to open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250729111537.GC1877762@horms.kernel.org>
Date: Tue, 29 Jul 2025 12:15:37 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	Alexander Duyck <alexanderduyck@...com>, mohsin.bashr@...il.com,
	vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net] eth: fbnic: unlink NAPIs from queues on error to open

On Mon, Jul 28, 2025 at 09:31:29AM -0700, Jakub Kicinski wrote:
> CI hit a UaF in fbnic in the AF_XDP portion of the queues.py test.
> The UaF is in the __sk_mark_napi_id_once() call in xsk_bind(),
> NAPI has been freed. Looks like the device failed to open earlier,
> and we lack clearing the NAPI pointer from the queue.
> 
> Fixes: 557d02238e05 ("eth: fbnic: centralize the queue count and NAPI<>queue setting")
> Reviewed-by: Alexander Duyck <alexanderduyck@...com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks,

I agree that the cited commit should have updated the unwind path as per
this patch.

Reviewed-by: Simon Horman <horms@...nel.org>