netdev - Re: [PATCH net v4 2/2] selftests/tc-testing: Check backlog stats in gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TEN7juelysWV9lXIS7_4UsroEIbaZrmF-WdmPLPxsm6UBYNcd_kUFDQ59nOufuRqVltQs8v9Dadv4zugCJrcFnBVMZbJXx2bAvXBiP-eNSU=@willsroot.io>
Date: Wed, 30 Jul 2025 17:59:38 +0000
From: William Liu <will@...lsroot.io>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, pabeni@...hat.com, kuba@...nel.org, jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com, horms@...nel.org, savy@...t3mfailure.io, victor@...atatu.com
Subject: Re: [PATCH net v4 2/2] selftests/tc-testing: Check backlog stats in gso_skb case

On Wednesday, July 30th, 2025 at 5:54 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:

> 
> 
> On Sun, Jul 27, 2025 at 11:57:10PM +0000, William Liu wrote:
> 
> > + "setup": [
> > + "$IP link set dev $DUMMY up || true",
> > + "$IP addr add 10.10.11.10/24 dev $DUMMY || true",
> > + "$TC qdisc add dev $DUMMY root handle 1: tbf rate 8bit burst 100b latency 100ms",
> > + "$TC qdisc replace dev $DUMMY handle 2: parent 1:1 hhf limit 1000",
> > + [
> > + "ping -I $DUMMY -c2 10.10.11.11",
> > + 1
> > + ],
> 
> 
> Sorry, I still have troubles understanding the magic "1" here, and I
> don't find any other selftest using it. So why do we need it here?
> 
> You said it is in the original reproducer, but the original reproducer
> is not part of tc-testing. This does not explain to me.
> 
> Thanks.

Oh, that was the magic number you were referring to? That is the expected return code for ping in that case, and must be specified if a command in the setup returns non-zero. 

This behavior is documented in the tc-testing READMEs, under creating-testcases/AddingTestCases.txt (section SETUP/TEARDOWN errors).