netdev - Re: [RFC PATCH] ethtool: add FEC bins histogramm report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250730064419.2588a5e3@kernel.org>
Date: Wed, 30 Jul 2025 06:44:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Andrew Lunn <andrew@...n.ch>, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, intel-wired-lan@...ts.osuosl.org, Donald
 Hunter <donald.hunter@...il.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] ethtool: add FEC bins histogramm report

On Wed, 30 Jul 2025 10:18:46 +0100 Vadim Fedorenko wrote:
> > IDK, 0,0 means all symbols were completely correct.
> > It may be useful for calculating bit error rate?  
> 
> The standard doesn't have this bin, its value can be potentially
> deducted from all packets counter.

We have a number of counters outside of the standard. Here the
extension is pretty trivial, so I don't see why we'd deprive
the user of the information HW collects. The translation between
bytes and symbols is not exact. Not sure we care about exactness
but, again, trivial to keep the 0,0 bin.

> > A workaround for having the {-1, -1} sentinel could also be to skip
> > the first entry:
> > 
> > 	if (i && !ranges[i].low && !ranges[i].high)
> > 		break;  
> 
> I was thinking of this way, the problem is that in the core we rely on
> the driver to provide at least 2 bins and we cannot add any compile-time
> checks because it's all dynamic.

1 bin is no binning, its not a legit use of the histogram API. 
We have a counter for corrected symbols already, that's the "1 bin".